[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: three tiny doc-only patches

From: Eric Blake
Subject: Re: three tiny doc-only patches
Date: Sat, 06 Jun 2009 10:02:06 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20090302 Thunderbird/ Mnenhy/

Hash: SHA1

According to Jim Meyering on 6/6/2009 9:49 AM:
> I found an old branch with these on it.
> Any objection or suggestion?
>    $ $[0] AUTOTEST_PATH=bin
> -possibly amounts into
> +is equivalent to this, when run from /tmp/foo-1.0:
> -  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH
> +  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH $[0]

That assumes a VPATH build with /src as the --srcdir and /tmp as the build
location, but the addition of $0 to the output does make it read better.

>>From 58bfc2249179517831fb248a17e910b4ab010afe Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Wed, 10 Dec 2008 09:58:09 +0100
> Subject: [PATCH 2/3] * doc/gnu-oids.texi: Remove trailing blank and trailing 
> empty line.

No.  This file is pulled from upstream, via 'make fetch', and will just
revert during the next pull.  Besides, .gitattributes already exempts it.
 The proper fix would need to be fed upstream.

>>From 76a1b4c3abd3bca0db498ef00bf94a8396613b01 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Wed, 10 Dec 2008 10:19:16 +0100
> Subject: [PATCH 3/3] testsuite--help

That subject line could use a space.

>    $ $[0] AUTOTEST_PATH=bin
> -is equivalent to this, when run from /tmp/foo-1.0:
> +is equivalent to this, where /src/foo-1.0 is the directory:

s/the directory/the source directory/

With those nits, it means patch 1 and 3 now use consistent wording, so I
would be okay with squashing those into one patch and applying.  Let me
know if you want me to do the grunt work.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]