[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_INIT: properly quote package name containing m4 macro

From: Eric Blake
Subject: Re: [PATCH] AC_INIT: properly quote package name containing m4 macro
Date: Mon, 21 Mar 2011 08:00:23 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 03/20/2011 11:32 AM, Dave Hart wrote:
> By my reading, Eric is proposing to require the first argument, the
> package name, be unexpanded.  You care about the 2nd argument being
> expanded, so I'm wondering if Eric's proposal impacts your use at all.

Not quite - my proposal was an all or none proposition, initially
leaning towards none.

> If expanding AC_INIT's second argument would be impacted, I think NTP
> may be affected as well:
> m4_include([sntp/m4/version.m4])
> AC_PREREQ([2.61])
>     [ntp],

But given that uses like this exist in the wild, I've changed my mind -
you are correct that the only reasonable approach is to expand all
arguments.  I will have to adjust the patch accordingly; the goal is that:

AC_INIT([[my-changequote-package]], [1.0])

should allow you to name a package with 'changequote' in the title, but
without extra [].

However, it will probably be a few days before I have a working approach.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]