[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.

From: Eric Blake
Subject: Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.
Date: Mon, 23 Sep 2013 07:44:20 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/21/2013 06:05 PM, Zack Weinberg wrote:
> On Sat, Sep 21, 2013 at 9:29 AM, Eric Blake <address@hidden> wrote:
>> On 09/14/2013 10:22 AM, Zack Weinberg wrote:
> ...
>>>    (AC_HEADER_STDC, AC_UNISTD_H): AU_DEFUN to trigger
>>>    _AC_INCLUDES_DEFAULT_REQUIREMENTS if it hasn't already happened,
>>>    and do nothing else.
> ...
>> Ah, I see what you did - you expanded to ac_dummy="AC_INCLUDES_DEFAULT"
>> rather than actually spelling out the internal macro name - it triggers
>> the internal macro via AC_REQUIRES magic.  Interesting :)
> Right.  (In case you're wondering, the AS_IF is to ensure that the
> AC_REQUIRE expansion happens before the beginning of the
> ac_dummy="..." statement.)
> Given that, do you still want patch 6?

Yes, patch 6 is still worthwhile.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]