[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert 'Fix logic error in _AC_PROG_LEX_YYTEXT_DECL (#109320

From: Paul Eggert
Subject: Re: [PATCH] Revert 'Fix logic error in _AC_PROG_LEX_YYTEXT_DECL (#109320)'
Date: Thu, 16 Jul 2020 17:50:20 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 7/16/20 11:40 AM, Zack Weinberg wrote:
I believe that what's in trunk now should work fine for
cross-compilation of programs that don't require yywrap

I thought so too, but after eyeballing the trunk a bit I noticed a shell portability bug in the recently-added AC_PROG_LEX code. I then found a couple more instances of the same bug elsewhere in Autoconf (in rarely-executed code, I think).

The problem is that constructs like ${ac_lib:-none needed} don't conform to POSIX, as POSIX requires that the stuff after the :- be a single shell word. (The next time I meet Steve Bourne I want to give him an earfull....)

I installed a doc patch describing the portability pitfall into Savannah master:

and would like to also install the attached patch to fix the code bugs. I have held off installing this latter patch, though, as I don't want to get in the way of whatever testing you're doing.

Attachment: 0001-Fix-VAR-NONWORD-bugs.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]