[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_LANG_INT_SAVE: Modernize function declarators (C89 and ab

From: Eric Blake
Subject: Re: [PATCH] AC_LANG_INT_SAVE: Modernize function declarators (C89 and above).
Date: Wed, 5 Aug 2020 09:40:08 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 8/5/20 9:24 AM, Paul Eggert wrote:
On 8/5/20 3:59 AM, Vincent Lefevre wrote:
This allows one to avoid a failure with AC_COMPUTE_INT when using
the -Werror=old-style-definition GCC option.

Why is this needed? Telling 'configure' to use -Werror has never worked, for lots of other reasons.

It may not be needed on that front, but at the same time, I don't see it as hurting. We can't guarantee that all configure snippets compile warning-free, but where a warning is easy to avoid, we might as well do it.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization: |

reply via email to

[Prev in Thread] Current Thread [Next in Thread]