[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_LANG_INT_SAVE: Modernize function declarators (C89 and ab

From: Paul Eggert
Subject: Re: [PATCH] AC_LANG_INT_SAVE: Modernize function declarators (C89 and above).
Date: Thu, 6 Aug 2020 18:50:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 8/6/20 4:25 PM, Vincent Lefevre wrote:
IMHO, in the mean time, a "void" for the parameter list should be
used when it makes sense.

For what it's worth, I count 13 instances of 'int main (void) { ... }' in Gnulib code, and 136 instances of 'int main () { ... }'. As I recall, the latter is for C++ compatibility, which I guess is not an issue with MPFR.

It's not a big deal either way, but if it helps MPFR out I suppose it's a win. I installed the attached two patches. The first one fixes the problem you mentioned, along with a similar issue in the 'inline' detection. The second one fixes a related problem with 'int main (int argc)'.

Attachment: 0001-Pacify-Werror-in-two-places.patch
Description: Text Data

Attachment: 0002-Avoid-one-argument-main.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]