[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Minor improvements for tests `acloca*.test'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Minor improvements for tests `acloca*.test'. |
Date: |
Wed, 11 Aug 2010 06:05:24 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Wed, Aug 11, 2010 at 01:28:44AM CEST:
> Being forced to rescan this patch some time after having written it,
> I must admit that the noise-to-improvement ratio is way too high.
> So OK, let's drop most of this patch. However, I'd like to retain
> a couple of changes more than the ones blessed by you here.
>
> WDYT about the trimmed-down attached patch?
Still high, but OK for maint.
Thanks,
Ralf
> Tweak and/or extend some `acloca*.test' tests.
>
> * tests/aclocal8.test: Ensure verbose printing of captured
> output.
> * tests/aclocal.test: Likewise. Also, add trailing `:'
> command.
> * tests/acloca19.test: Likewise.
> * tests/aclocal5.test: Add trailing `:' command, and prefer
> `$me' over hard-coded test name.
> * tests/aclocal6.test: Likewise.
> * tests/aclocal18.test: Add trailing `:' command, and make
> some grepping slighty stricter.
> * tests/acloca14.test: Likewise. Also, prefer `diff' over
> `cmp', and add some "cosmetic" blank lines.