Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test !

automake-patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test !

From:	Bruno Haible
Subject:	Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test ! -f'
Date:	Mon, 6 Sep 2010 22:48:20 +0200
User-agent:	KMail/1.9.9

Hi Stefano,

> Internationalization tests: prefer `test ! -r' over `test ! -f'

Why? Why is it more important to check that an expected file has
read permissions, than to check that it is a regular file?

This is not an objection. I just find it odd to use 'test -f' for
the positive test and 'test ! -r' for the negative one.

Technically the patch is OK with me.

Bruno

[Prev in Thread]

Current Thread

[Next in Thread]

Re: shell errexit and exit status (was: [PATCH] Internationalization tests: do not ignore failures.), (continued)

Prev by Date: Re: [PATCH] Internationalization tests: prefer `make distdir' over `make dist'.
Next by Date: Re: [PATCH] Internationalization tests: do not ignore failures.
Previous by thread: Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test ! -f'
Next by thread: Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test ! -f'
Index(es):
- Date
- Thread