automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test !


From: Stefano Lattarini
Subject: Re: [PATCH] Internationalization tests: prefer `test ! -r' over `test ! -f'
Date: Tue, 7 Sep 2010 03:45:32 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Hello Ralf.  It seems you are confusing "set -e" and "set -r"...

On Tuesday 07 September 2010, Ralf Corsepius wrote:
>   On 09/06/2010 07:51 PM, Ralf Wildenhues wrote:
> > Hello Ralf,
> > 
> > * Ralf Corsepius wrote on Mon, Sep 06, 2010 at 07:49:04PM CEST:
> >> On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
> >>> This is mostly a cosmetic/consistency patch.  I hope you'll
> >>> find it worth applying nonetheless.
> >>> Internationalization tests: prefer `test ! -r' over `test ! -f'
> >> 
> >> test -r is non-portable.
> >> 
> >> Very old shells do not support it.
> > 
> > Do you have an example system? 
> SunOS4.
> 
> I still have access to its man-pages, which don't mention "test -e".
Well, "test -e" is still not supported by Solaris 10 /bin/sh.  But
"test -r", which we are talking about, should have been there from
a really really long time -- it is even cited in the Kernighan/Pike
"The UNIX programming environment"!

> > The Autoconf manual doesn't bother to document this, which makes
> > me think that only museum systems would be affected.
> 
> Quite likely.
> 
> >  We've been using it for a long time inside both Autoconf and
> > Automake.
> 
> I vaguely recall somebody having wanted to use "test -e"
> in autoconf in the 2.13->2.49-era and him having triggered issues
> related to it. May be times have changed enough to further on
> ignore the number of such remaining fossil systems?
Alas, we can't do this yet -- thanks, Solaris!

Regards,
   Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]