automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] tests: upgrade and fix Bison test case


From: Stefano Lattarini
Subject: Re: [PATCH 1/4] tests: upgrade and fix Bison test case
Date: Sat, 14 Jul 2012 11:16:13 +0200

On 07/14/2012 10:52 AM, Akim Demaille wrote:
> 
> Le 14 juil. 2012 à 10:49, Stefano Lattarini a écrit :
> 
>> Hi Akim.
>>
>> ACK, with one question ...
>>
>>> cat > foo.cc << 'END'
>>> #include "zardoz.hh"
>>>
>>> -using namespace std;
>>> -
>> Why this change?
> 
> Well, the question is rather: why this line?  It's useless,
> like a useless #include.
> 
I often add a "using namespace std;" or "#include <iostream>" line
to C++ sources to ensure they are not valid C, so that any attempt
on part of Automake-generated Makefiles to compile them using the
C compiler would cause a clear error.  Mostly paranoid, granted,
but easy to do, and I always welcome extra coverage.

In this case, the point is moot, because other constructs in foo.cc
makes it invalid as C anyway; still, I dislike seeing gratuitous
edits like the one above in the middle of patches doing unrelated
changes.  Oh well, no big deal for this time.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]