[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] tests: upgrade and fix Bison test case
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 1/4] tests: upgrade and fix Bison test case |
Date: |
Sat, 14 Jul 2012 11:16:13 +0200 |
On 07/14/2012 10:52 AM, Akim Demaille wrote:
>
> Le 14 juil. 2012 à 10:49, Stefano Lattarini a écrit :
>
>> Hi Akim.
>>
>> ACK, with one question ...
>>
>>> cat > foo.cc << 'END'
>>> #include "zardoz.hh"
>>>
>>> -using namespace std;
>>> -
>> Why this change?
>
> Well, the question is rather: why this line? It's useless,
> like a useless #include.
>
I often add a "using namespace std;" or "#include <iostream>" line
to C++ sources to ensure they are not valid C, so that any attempt
on part of Automake-generated Makefiles to compile them using the
C compiler would cause a clear error. Mostly paranoid, granted,
but easy to do, and I always welcome extra coverage.
In this case, the point is moot, because other constructs in foo.cc
makes it invalid as C anyway; still, I dislike seeing gratuitous
edits like the one above in the middle of patches doing unrelated
changes. Oh well, no big deal for this time.
Thanks,
Stefano
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, (continued)
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Stefano Lattarini, 2012/07/13
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Akim Demaille, 2012/07/13
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Stefano Lattarini, 2012/07/13
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Akim Demaille, 2012/07/14
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Akim Demaille, 2012/07/14
- Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers, Stefano Lattarini, 2012/07/14
- [PATCH 0/4] ylwrap: support C++ and others that generate several files, Akim Demaille, 2012/07/14
- [PATCH 1/4] tests: upgrade and fix Bison test case, Akim Demaille, 2012/07/14
- Re: [PATCH 1/4] tests: upgrade and fix Bison test case, Stefano Lattarini, 2012/07/14
- Re: [PATCH 1/4] tests: upgrade and fix Bison test case, Akim Demaille, 2012/07/14
- Re: [PATCH 1/4] tests: upgrade and fix Bison test case,
Stefano Lattarini <=
- Re: [PATCH 1/4] tests: upgrade and fix Bison test case, Akim Demaille, 2012/07/14
- [PATCH 2/4] ylwrap: refactoring: don't rely on the file order, Akim Demaille, 2012/07/14
- [PATCH 3/4] ylwrap: refactor: move loop invariant, Akim Demaille, 2012/07/14
- [PATCH 4/4] ylwrap: fix C++ support, Akim Demaille, 2012/07/14
- Re: [PATCH 4/4] ylwrap: fix C++ support, Stefano Lattarini, 2012/07/14
- Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files, Stefano Lattarini, 2012/07/14
- Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files, Stefano Lattarini, 2012/07/14
- yacc-work: rebased on maint, one more fixlet (was: Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files), Stefano Lattarini, 2012/07/14
- Re: yacc-work: rebased on maint, one more fixlet (was: Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files), Akim Demaille, 2012/07/14
- Re: yacc-work: rebased on maint, one more fixlet, Stefano Lattarini, 2012/07/14