Re: [PATCH 1/4] tests: upgrade and fix Bison test case

[Akim Demaille]

Le 14 juil. 2012 à 11:16, Stefano Lattarini a écrit :

> I often add a "using namespace std;" or "#include <iostream>" line
> to C++ sources to ensure they are not valid C, so that any attempt
> on part of Automake-generated Makefiles to compile them using the
> C compiler would cause a clear error.  Mostly paranoid, granted,
> but easy to do, and I always welcome extra coverage.
> 
> In this case, the point is moot, because other constructs in foo.cc
> makes it invalid as C anyway; still, I dislike seeing gratuitous
> edits like the one above in the middle of patches doing unrelated
> changes.  Oh well, no big deal for this time.

It was related: that coding style issues.  "using namespace std"
weakens the quality of the test – yet granted this is more for
Bison's own test suite, than Automake's :)

If I were to check that we do compile C++, I'd use __cplusplus,
which, besides, is self documenting.