Re: [FYI] {maint} automake: don't define many identical 'lang_*_rewrite' subroutines

[Stefano Lattarini]

On 08/27/2012 06:10 PM, Peter Rosin wrote:
> On 2012-08-27 17:46, Stefano Lattarini wrote:
>> This is just a simplifying refactoring, with no semantic change intended.
>>
>> Cherry-picked from the Automake-NG commit 'v1.12.1-312-g63aa4a9' of
>> 2012-06-07.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>  automake.in | 93 
>> ++++---------------------------------------------------------
>>  1 file changed, 5 insertions(+), 88 deletions(-)
>>
>> diff --git a/automake.in b/automake.in
>> index a9c1a06..1835f6d 100644
>> --- a/automake.in
>> +++ b/automake.in
>> @@ -1749,6 +1749,7 @@ sub handle_single_transform ($$$$$%)
>>          # generates another source file which we must then process
>>          # further.
>>          my $subr = \&{'lang_' . $lang->name . '_rewrite'};
>> +            defined &$subr or $subr = \&lang_sub_obj;
>>          my ($r, $source_extension)
> 
> Nitpicking...but...inconsistent whitespace.
>
More precisely, indentation with white spaces rather than tabs (which
are used by surrounding code) ...  I'm using space-based indentation
in all the new changes, as I strongly prefer it.  I agree consistency
would be nice, but you don't want me to write a mega-patch converting
all leading tabs to white spaces in the name of consistency, do you? ;-)

Regards,
  Stefano