automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {maint} automake: don't define many identical 'lang_*_rewrite'


From: Stefano Lattarini
Subject: Re: [FYI] {maint} automake: don't define many identical 'lang_*_rewrite' subroutines
Date: Mon, 27 Aug 2012 21:37:12 +0200

On 08/27/2012 07:57 PM, Peter Rosin wrote:
> On 2012-08-27 19:21, Stefano Lattarini wrote:
>> On 08/27/2012 06:10 PM, Peter Rosin wrote:
>>> Nitpicking...but...inconsistent whitespace.
>>>
>> More precisely, indentation with white spaces rather than tabs (which
>> are used by surrounding code) ...  I'm using space-based indentation
>> in all the new changes, as I strongly prefer it.  I agree consistency
>> would be nice, but you don't want me to write a mega-patch converting
>> all leading tabs to white spaces in the name of consistency, do you? ;-)
> 
> Err, no thanks.  But I just assumed that whatever personal preference
> a person could have, the resulting inconsistency from changing the
> indentation on individual lines would be more disturbing than having
> the wrong kind of whitespace.
>
True, but the inconsistency had already slipped in Automake-NG anyway, so ...
but what the hell, it's just one line, and any merge conflict will be trivial
to fix, so I've amended the patch to keep the indentation of the new line
consistent with that of the surrounding code (that is, using leading tabs).

Thanks for the sanity check,
   Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]