automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: t/txinfo-vtexi4.sh and timezone failure


From: Jim Meyering
Subject: Re: t/txinfo-vtexi4.sh and timezone failure
Date: Fri, 20 Dec 2019 22:22:46 -0800

On Fri, Dec 20, 2019 at 6:15 PM Karl Berry <address@hidden> wrote:
>
> The automake test t/txinfo-vtexi4.sh failed when localtime and UTC were
> on different days, resulting in the GREPDATE for the @UPDATED@ string
> not matching (among possible others).
>
> mdate-sh always uses TZ=UTC0. This tiny change makes the test do the
> same thing.
>
> I wondered if there were other tests that might have the same problem,
> e.g., if TZ would be better set in test-init.sh (although granted this
> was the only one failing). However, install-sh-option-C.sh is the only
> other test that was setting TZ, and I didn't see others invoking date,
> either. So Jim and I figured just patching vtexi4 is reasonable.
>
> Unrelated but so trivial did not at all seem worth separating: the doc
> in vtexi4.sh referred to itself when it didn't mean to.
>
> Any comments or suggestions before I attempt to push this? --thanks, karl.

Good one. Thank you for tracking that down.
When I applied that, "git am FILE" warned about this:
.git/rebase-apply/patch:14: trailing whitespace.

So please amend that to remove the trailing space in NEWS.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]