Re: [Axiom-developer] Patches

[Martin Rubey]

Waldek Hebisch <address@hidden> writes:

> > here are some patches for bug #355.

> > By the way, I just found the documented version of the patch to STTAYLOR,
> > it is on MathAction, #312, powern.patch. I include a version that applies
> > smoothly to wh-sandbox here, too.

> I have a little problem with documentation parts.  In combfunc.spad.pamphlet
> part you write:
> 
> +      ++ Gamma(a,x) returns the incomplete Gamma function applied to a and x.
> +      ++ Concerning differentiation, it is regarded as a function in the 
> second
> +      ++ argument only.
> 
> This behaviour is clearly a bug.

Hm, I thought this at first, too.  But the behaviour is consistent for Gamma,
Bessel and Polygamma.  It is not difficult to change this behaviour to leaving
the derivative unevaluated, but I'm not sure whether that would really be
better.  If you are absolutely sure, please let me know as soon as possible.
How about polygamma?  should D(polygamma(x, x), x) throw an error?  I guess so.
But if we follow you, Bessel* should leave the derivative with respect to the
first argument - i.e., leave it unevaluated.

> In sttaylor.spad.pamphlet part you put explanations after corresponding code.
> I find this confusing, I think that putting explanations before code is much
> clearer.

I don't, but I realise that noweb behaves so that your style is preferred. -
OK.  Do you want me to change this for these two patches already?

> > Waldek: do you prefer if I commit to your branch myself, or is this form
> > good for you, too?
> > 
> 
> I general it is better if author of a patch applies it.  Currently we have
> low volume of patches and I can apply them myself if needed.  Still if I
> think that patch needs correction (as in this case) when I do the correction
> myself I may get something different than what you indended.  So it is better
> that you prepare corrected patch (or present some sting reason to keep patch
> as is) and once the new patch is approved apply it.

Hm, if I would have applied the patch myself, there probably would not have
been any review.  So, if you don't mind, for the time being with less then 10
developers, I would like to ask you to keep things as they are now, and we
change the system as soon as we are more than 10 developers, ok?  (Of course,
if you prefer to change the system right now, I follow you.)

Many many thanks for your committment :-)

Martin