Re: [Axiom-developer] aldor/axiom interoperability

[Gregory Vanuxem]

Le vendredi 14 mars 2008 à 08:03 +0000, Peter Broadbery a écrit : 
> On Thu, Mar 13, 2008 at 9:21 PM, Gregory Vanuxem <address@hidden> wrote:
> > Dear Peter, *
> >
> >  I was waiting for your small Aldor patch and never see it. Did you send
> >  it somewhere ? The main concern of this mail is if you are able to
> >  compile ecfact.as (attached) and _execute_ the
> >  LenstraEllipticMethod(Integer) function. On my system it fails, a bug
> >  somewhere. Am I alone with this issue ?  Martin ? I'm still using the
> >  old build process and want to switch to the new one but this stops me. I
> >  do not want to take your time but maybe you have an idea of what's going
> >  on with this issue.
> >
> ....
> apologies for the, um, delay..
> The following patch affects the build of libaxiom.al - if a given file
> compiles, then it will work or fail independently of this (it fixes
> the compilation of FRMOD amongst others).

Ok, it will not fix the bug previously mentioned but will allow to
switch and test the new build procedure, many thanks for your work !!!

> The hashcode fix _should_ help with runtime bugs.  It tracks the
> change to hashcodes marked 1_1_13_18 in gf_add.c
> 
> Index: src/sefo.c
> ===================================================================
> --- src/sefo.c        (revision 23)
> +++ src/sefo.c        (working copy)
> @@ -1361,7 +1361,9 @@
>       Bool    eq;
> 
>       sstNext("symeEqual", syme1, syme2);
> +
>       eq = symeEqual0(NULL, syme1, syme2);
> +
>       sstDoneSyme(syme1);
> 
>       return eq;
> @@ -1847,6 +1849,9 @@
>       if (tfIsDefine(tf1) || tfIsDefine(tf2))
>               return true;
> 
> +     if (tfIsThird(tf1) || tfIsThird(tf2))
> +             return true;
> +
>       if (tfTag(tf1) != tfTag(tf2))
>               return false;
>       if (tfArgc(tf1) != tfArgc(tf2))
> 

Applied, thanks. I'll let you know if I encounter any issues during the
switch. Hoping that it will be applied directly to the Aldor svn trunk.

Regards

Greg