bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [tim-3] Improved DJGPP support in src/files.c


From: Paul Eggert
Subject: Re: [tim-3] Improved DJGPP support in src/files.c
Date: Wed, 16 Jan 2002 00:50:04 -0800 (PST)

> From: Tim Van Holder <address@hidden>
> Date: 16 Jan 2002 08:13:19 +0100

> > #define ISSLASH(x) (! 
> > "...............................................\0............................................\0..................................................................................................................................................................."[(unsigned
> >  char) (x)])
> 
> Isn't that charset-specific?

Sure, but we're talking DOS here aren't we?  It uses ASCII.

> And the table approach would then have platform conditionals again
> (unless you're suggesting another macro that would define the table).

It's OK to put function-style macros into config.h.  Or maybe when Autoconf
gets around to generating system.h it could go there.

> Yes and no.  Yes if it's a macro, no if it's a function;

In programs that I help to maintain, I try to banish all such
functions to a pc/ or ms/ subdirectory and let the Microsoft-oriented
folks maintain the contents of those directories using whatever tools
they like.  The Microsoft-oriented stuff tends to get stale pretty
quickly, so those subdirectories mostly end up being notes about
ancient ports.  I don't think these maintenance issues should be
central to Autoconf.  If it's easy to maintain that stuff, fine; I
just don't want to spend a lot of our limited time on it.

> 1) No filesys prefix (\FOO\BAR) -> 0
> 2) Drivespec (C:\FOO\BAR) -> 2
> 3) UNC (\\NETWORKSHARE\FOO\BAR) -> len(sharename)

Hmm, if UNCs are special, the current dirname/basename code doesn't
work.  I suspect a lot of existing GNU code won't work for case 2)
either.  I'm not sure it's worth our time to port it all.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]