bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [tim-3] Improved DJGPP support in src/files.c


From: Akim Demaille
Subject: Re: [tim-3] Improved DJGPP support in src/files.c
Date: 17 Jan 2002 12:00:12 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp)

>>>>> "Paul" == Paul Eggert <address@hidden> writes:

Paul> That wouldn't be reasonable, since the semantics have diverged.
Paul> dir_name and base_name are reentrant and never modify their
Paul> arguments; that is not true of dirname and basename.  These
Paul> days, quite a bit of code relies on the nicer semantics of
Paul> dir_name and base_name.

BTW, there is something that I would like very much: have two
signatures for basename:

const char *basename_const (const char *name);

and

char *basename (const char *name);

I would really like to have the first one too, without any cast at
all, so that:

src/bison-exp/lib % gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -I.. -I../src 
-I../intl -I../lib    -g -O2  -c basename.c -Wcast-qual          
basename.c: In function `base_name':
basename.c:70: warning: cast discards qualifiers from pointer target type

we can avoid this problem.  I know the warning from GCC is not very C
compliant, and that we can't express the real dependency, but having
two functions, with two names can help.

If I provide the patch to basename.c, would it be accepted?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]