Re: [PATCH] Add new files for IELR and canonical LR implementation.

[Akim Demaille]

Le 21 avr. 09 à 12:29, Joel E. Denny a écrit :

> In wrote many of these files with OO in mind.  As a result, I used
> customary OO capitalization.  I also chose "__" as my namespace  
> delimiter.
> If these conventions are too objectionable to others, I'll make some
> commits later to conform.  Opinions?

I'm fine with the goal, but I am uncomfortable with the file names: we  
should stick to lower case (LR0 is an exception I meant to solve for a  
long time).  The order in which they appear in ls (or in the Makefile  
if we pay attention to sorting them) depends on the locale, which is  
not a nice feature imho.  Also, I prefer using a separator in the file  
names, where the change of case plays that role in identifiers.  So I  
would use annotation-list.* to match what we did up to now.  Some  
names were "mangled" (e.g., symlist) thinking about broken file- 
systems that have only 8+3 relevant characters in their file names.  I  
have no idea whether this constraint should still be observed.

A simple underscore seems enough to me, like in some other files.   
Also, it seems that some member functions have mixed case and others  
do not depending on their visibility (private/public).  I stick to  
lower case for C++ member functions, as is the case in STL and Boost  
(though, I agree, they also use lower case for class names), and use a  
trailing underscore to mark private attributes.

I have not read the patches in detail, can't comment about them, yet.