bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/7] glr.cc: fatal if using api.token.ctor without variants


From: Akim Demaille
Subject: Re: [PATCH 2/7] glr.cc: fatal if using api.token.ctor without variants
Date: Fri, 11 Jan 2013 12:59:07 +0100

Le 11 janv. 2013 à 13:28, Theophile Ranquet <address@hidden> a écrit :

> * data/glr.cc: Here.
> ---
> data/glr.cc | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> diff --git a/data/glr.cc b/data/glr.cc
> index 1688d3d..0d7e03a 100644
> --- a/data/glr.cc
> +++ b/data/glr.cc
> @@ -43,6 +43,14 @@
> #   user must initialize the first positions (in particular the
> #   filename member).
> 
> +b4_token_ctor_if([b4_variant_if([],
> +                                
> [b4_fatal_at(b4_percent_define_get_loc(api.token.constructor),
> +                                             [cannot use '%s' without '%s'],
> +                                             [%define api.token.constructor],
> +                                             [%define api.value.type 
> variant])

Please, unindent the b4_fatal_at (just two initial spaces).

> +                                )])],

You can close without leaving this \n.

> +                [])

useless else.

> +
> # We require a pure interface.
> m4_define([b4_pure_flag],      [1])
> 
> -- 
> 1.8.1
> 
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]