Re: [PATCH] {msvc} Regenerate with autoconf 2.67

[Stefano Lattarini]

On Wednesday 15 September 2010, Eric Blake wrote:
> On 09/15/2010 09:34 AM, Stefano Lattarini wrote:
> >>>> - [ "$LINENO" AS_MESSAGE_LOG_FD])])
> >>>> + [ "$LINENO" AS_MESSAGE_LOG_FD ])])
> >>> 
> >>> How nice of Debian to not tell upstream about the issue :(
> >> 
> >> Does anyone know which Debian bug this patch is supposed to
> >> address?
> > 
> > Wild guess: might it have been this one?
> > 
> >   <http://lists.freedesktop.org/archives/pkg-config/2010-August/0
> >   00631.html>
> > 
> > (which has since been fixed in the pkg-config git repo, BTW). 
> > There should be a reference also on the autoconf list
> > somewhere...
> 
> Probably the same issue, indeed.  I still haven't tried to track
> down a URL to the pkg-config macro in question, though, to
> ascertain whether it was a quoting error in pkg-config or in
> autoconf,
You might want to look at commit 2b86e9b4664fd43622e2cd5ab47713a818758970
in the pkg-config git repository:

commit 2b86e9b4664fd43622e2cd5ab47713a818758970
Author:     Tollef Fog Heen <address@hidden>
AuthorDate: Thu Aug 19 08:54:09 2010 +0200
Commit:     Tollef Fog Heen <address@hidden>
CommitDate: Thu Aug 19 08:54:09 2010 +0200

    Add some []s before dnl
    
    Autoconf 2.66 has some problems with missing []s before dnls, causing
    the expanded text to be garbled.
    
    Fixes #29056

diff --git a/pkg.m4 b/pkg.m4
index 9bb3e06..31169b4 100644
--- a/pkg.m4
+++ b/pkg.m4
@@ -135,7 +135,7 @@ $$1_PKG_ERRORS
 Consider adjusting the PKG_CONFIG_PATH environment variable if you
 installed software in a non-standard prefix.
 
-_PKG_TEXT])dnl
+_PKG_TEXT])[]dnl
         ])
 elif test $pkg_failed = untried; then
        AC_MSG_RESULT([no])
@@ -146,7 +146,7 @@ path to pkg-config.
 
 _PKG_TEXT
 
-To get pkg-config, see <http://pkg-config.freedesktop.org/>.])dnl
+To get pkg-config, see <http://pkg-config.freedesktop.org/>.])[]dnl
         ])
 else
        $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS


> and whether autoconf should help out even if pkg-config
> was the one with insufficient quoting.
I leave this one to the experts ;-)

Regards,
  Stefano