Re: [GNU Autoconf 2.69.23-388d] testsuite: 35 failed (autom4te preselections)

[Stefano Lattarini]

On 09/21/2012 11:20 PM, Eric Blake wrote:
> On 09/21/2012 01:34 PM, Stefano Lattarini wrote:
>> On 09/21/2012 05:50 PM, Eric Blake wrote:
> 
>>>> ./tools.at:1200: test "`find configure -newer newer`" = "" ||
>>>>      { diff old-requests autom4te.cache/requests; exit 1; }
>>>
>>> Eww - we should really sort these things, so that the diff isn't so hard
>>> to read.  And use 'diff -u' instead of 'diff'.  Improvements to the
>>> testsuite just to make diagnosing the failure easier would be welcome.
>>>
>> I think I'll pass this time.
> 
> Okay, I'll handle that part.  Meanwhile,
> 
>> Subject: [PATCH] autom4te: update Automake preselections to reflect the 
>> changes in 1.12.x
>>
>> Issue revealed by a failure in test "35: tools.at: autom4te preselections":
>> <http://lists.gnu.org/archive/html/bug-autoconf/2012-09/msg00020.html>
>>
>> * lib/autom4te.in: Add 'AM_PROG_MKDIR_P'.
>>
>> Helped-by: Eric Blake <address@hidden>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>  lib/autom4te.in | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> ACK with one nit.
>
Oops. I had already pushed the patch with the rest of the batch.  Sorry!

>> diff --git a/lib/autom4te.in b/lib/autom4te.in
>> index a560501..d042fd8 100644
>> --- a/lib/autom4te.in
>> +++ b/lib/autom4te.in
>> @@ -69,6 +69,8 @@ args: --preselect AM_PROG_CXX_C_O
>>  args: --preselect AM_PROG_F77_C_O
>>  args: --preselect AM_PROG_FC_C_O
>>  args: --preselect AM_PROG_MOC
>> +# Will be removed in Automake 1.14.
>> +args: --preselect AM_PROG_MKDIR_P
> 
> Please also mention AM_PROG_MKDIR_P in the comment, so it is obvious
> which line it is meant to be associated with (and not a blanket
> statement about all further lines).
> 
Good idea.  What about the follow-up patch below?

Regards,
  Stefano

-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----

>From 74852e47487de4901db68716e433e9bf7cb878b4 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Sat, 22 Sep 2012 09:48:30 +0200
Subject: [PATCH] cosmetics: slightly improve a comment

* lib/autom4te.in: Here, the comment about 'AM_PROG_MKDIR_P'.

Suggested-by: Eric Blake <address@hidden>
Signed-off-by: Stefano Lattarini <address@hidden>
---
 lib/autom4te.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/autom4te.in b/lib/autom4te.in
index d042fd8..bc7ce73 100644
--- a/lib/autom4te.in
+++ b/lib/autom4te.in
@@ -69,7 +69,7 @@ args: --preselect AM_PROG_CXX_C_O
 args: --preselect AM_PROG_F77_C_O
 args: --preselect AM_PROG_FC_C_O
 args: --preselect AM_PROG_MOC
-# Will be removed in Automake 1.14.
+# AM_PROG_MKDIR_P will be removed in Automake 1.14.
 args: --preselect AM_PROG_MKDIR_P
 args: --preselect AM_SILENT_RULES
 args: --preselect AM_XGETTEXT_OPTION
-- 
1.7.12.317.g1c54b74