bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bash40-011 patch can't be applied cleanly


From: Bob Proulx
Subject: Re: bash40-011 patch can't be applied cleanly
Date: Thu, 19 Nov 2009 12:55:41 -0700
User-agent: Mutt/1.5.18 (2008-05-17)

Sergei Steshenko wrote:
> Greg Wooledge wrote:
> > And the only way you'll know that is by reading the patch itself.
>
> No, there shouldn't be

But so it is just the same.  Patches may be created in different ways
and that causes the recorded paths to either have no leading
directories, one leading directory, or many leading directories.  You
need to look in the patch file to determine how many leading
directories exist.

> there shouldn't be any need in human intervention, there should be a
> convention followed by participants of a given project.

Chet's patches all need -p0.  That is the convention for bash.  It is
a good convention.  You can apply all of Chet's patches using -p0
without looking inside them.  But that isn't a general statement about
using patch everywhere.  In general you will need to look in the
patch, look at the paths used, and use the appropriate -pNUM option.

> There is no need to waste time on routine tasks. And, if you wish, there
> shouldn't be "bazaar" in this case.

There is no standard for creating patches.  Different people desire
different behavior.  Therefore patches from different people will be
created differently.  That is just the way that it is.

If this is the biggest of your issues then you are in great shape! :-)

Bob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]