[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS lockdir bug with repository symlinks

From: Derek Robert Price
Subject: Re: CVS lockdir bug with repository symlinks
Date: Tue, 23 Mar 2004 15:16:38 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

Hash: SHA1

Ambalu, Robert wrote:

>sorry, I did mean 1.11.2
>I really wouldn't have time to do all these tests.  I can tell you that
>patch has been working for us at Goldman Sachs for over a year now.  We
>a 1000+ user base which make use of our repository daily.
>I guess we'll most likely submit the patch to Project Issues and hope it
>gets picked up...
>- Rob

Just because you haven't seen problems doesn't mean that they wouldn't
be seen in other environments nor that the code wouldn't eventually get
broken.  You can read the HACKING file for the full official rationale
behind the policy, but basically, code that isn't tested and documented
tends to get broken quickly with all the changes that go into CVS.
Therefore we just plain don't accept code without tests and documentation.

Tests and documentation also have the handy side effect of explaining to
the rest of us explicitly exactly what you expect the change to
accomplish.  Even though I suspect many submitters think their
intentions are obvious, once tests cases are written to explore edge
cases and possible side effects, problems and unconsidered side effects
are often exposed.  Documenting the changes can have similar side effects.

Regardless, thanks for the submission,

- --

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]