Feature Branch Windows Build Broken - lib/canonicalize.c - ELOOP & lstat

[Conrad T. Pino]

Hi All,

The new module "lib/canonicalize.c" fails to compile because it references
the symbolic error "ELOOP" which Windows does not define.

The new module "lib/canonicalize.c" calls the "lstat" function and there
is no prototype and no implementation on Windows platform we support.

We use "CVS_LSTAT" macro in the "src" directory which maps to "wnt_lstat"
which we implement in "windows-NT/filesubr.c".  We also have "lib/stat.c"
module.

Currently the Windows build doesn't use the "lib/stat.c" module.

The questions raised appear to be:

1. Where should an "ELOOP" definition be placed?

2. How should the "ELOOP" value be selected?

3. Which approach is best to resolve "lib/canonicalize.c" and "lstat"?

An incomplete patch set to the Windows build files is below to allow the
Visual Studio IDE build to complete up to the EXE link.  I plan to commit
a complete fix once a consensus on the above issues emerges.

Conrad Pino

--------------------Configuration: cvsnt - Win32 Debug--------------------
Linking...
libdiff.lib(canonicalize.obj) : error LNK2001: unresolved external symbol _lstat
.\WinDebug\cvs.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.

cvs.exe - 2 error(s), 0 warning(s)


Index: cvsnt.dsp
===================================================================
RCS file: /cvs/ccvs/cvsnt.dsp,v
retrieving revision 1.30
diff -u -p -r1.30 cvsnt.dsp
--- cvsnt.dsp   8 Mar 2005 05:19:52 -0000       1.30
+++ cvsnt.dsp   24 May 2005 18:56:39 -0000
@@ -372,6 +372,10 @@ SOURCE=.\src\buffer.h
 # End Source File
 # Begin Source File
 
+SOURCE=.\lib\canonicalize.h
+# End Source File
+# Begin Source File
+
 SOURCE=.\src\client.h
 # End Source File
 # Begin Source File
@@ -448,6 +452,10 @@ SOURCE=.\lib\gettext.h
 # End Source File
 # Begin Source File
 
+SOURCE=.\lib\glob.h
+# End Source File
+# Begin Source File
+
 SOURCE=.\src\hardlink.h
 # End Source File
 # Begin Source File
Index: lib/libcvs.dsp
===================================================================
RCS file: /cvs/ccvs/lib/libcvs.dsp,v
retrieving revision 1.23
diff -u -p -r1.23 libcvs.dsp
--- lib/libcvs.dsp      17 May 2005 22:12:12 -0000      1.23
+++ lib/libcvs.dsp      24 May 2005 18:56:39 -0000
@@ -97,10 +97,18 @@ SOURCE=.\basename.c
 # End Source File
 # Begin Source File
 
+SOURCE=.\canonicalize.c
+# End Source File
+# Begin Source File
+
 SOURCE=.\closeout.c
 # End Source File
 # Begin Source File
 
+SOURCE=".\cycle-check.c"
+# End Source File
+# Begin Source File
+
 SOURCE=.\dirname.c
 # End Source File
 # Begin Source File
@@ -308,6 +316,10 @@ SOURCE=.\allocsa.h
 # End Source File
 # Begin Source File
 
+SOURCE=.\canonicalize.h
+# End Source File
+# Begin Source File
+
 SOURCE=".\chdir-long.h"
 # End Source File
 # Begin Source File
@@ -320,6 +332,14 @@ SOURCE="..\windows-NT\config.h"
 # End Source File
 # Begin Source File
 
+SOURCE=".\cycle-check.h"
+# End Source File
+# Begin Source File
+
+SOURCE=".\dev-ino.h"
+# End Source File
+# Begin Source File
+
 SOURCE=.\dirname.h
 # End Source File
 # Begin Source File
@@ -426,6 +446,10 @@ SOURCE=.\gettext.h
 # End Source File
 # Begin Source File
 
+SOURCE=.\glob.h
+# End Source File
+# Begin Source File
+
 SOURCE=.\glob_.h
 
 !IF  "$(CFG)" == "libcvs - Win32 Release"
@@ -457,6 +481,10 @@ SOURCE=.\md5.h
 # End Source File
 # Begin Source File
 
+SOURCE=.\mempcpy.h
+# End Source File
+# Begin Source File
+
 SOURCE="..\windows-NT\ndir.h"
 # End Source File
 # Begin Source File
@@ -465,6 +493,10 @@ SOURCE=.\pagealign_alloc.h
 # End Source File
 # Begin Source File
 
+SOURCE=".\path-concat.h"
+# End Source File
+# Begin Source File
+
 SOURCE=.\pathmax.h
 # End Source File
 # Begin Source File
@@ -497,6 +529,10 @@ SOURCE=.\setenv.h
 # End Source File
 # Begin Source File
 
+SOURCE=".\stat-macros.h"
+# End Source File
+# Begin Source File
+
 SOURCE="..\windows-NT\stdbool.h"
 # End Source File
 # Begin Source File
@@ -505,6 +541,10 @@ SOURCE="..\windows-NT\stdint.h"
 # End Source File
 # Begin Source File
 
+SOURCE=.\strdup.h
+# End Source File
+# Begin Source File
+
 SOURCE=.\system.h
 # End Source File
 # Begin Source File
Index: windows-NT/config.h
===================================================================
RCS file: /cvs/ccvs/windows-NT/config.h,v
retrieving revision 1.144
diff -u -p -r1.144 config.h
--- windows-NT/config.h 24 May 2005 16:38:08 -0000      1.144
+++ windows-NT/config.h 24 May 2005 18:56:40 -0000
@@ -1314,3 +1314,5 @@ char *sock_strerror (int errnum);
 /* getpagesize is missing on Windows, but 4096 seems to do the right
    thing. */
 #define getpagesize() 4096
+
+#define ELOOP -22