RE: Feature Branch Solaris Build Broken - lib/glob.c errors

[Conrad T. Pino]

Hi Derek,

> From: Derek Price [mailto:derek@ximbiot.com]
> >
> >I committed an inclusion immediately before "struct stat" forward
> >declaration to assure the Solaris "stat" macro is used but on 2nd
> >reflection the forward declaration is moot.  I'm considering it's
> >removal.  Any objection on your part?
> 
> No objections here.  Please do so.  Also, please shorten this comment to
> something like "get struct stat":
> 
>     /* Solaris may "#define stat stat64" in some cases */

Done.

We have a new warning in "lib/glob.c" compile:

        In file included from glob.h:100,
                         from glob.c:23:
        /usr/include/sys/stat.h:175: warning: `lstat' redefined
        ../config.h:1135: warning: this is the location of the previous 
definition

and prior "storage size of `st' isn't known" are still true.

Defining macro "__PRAGMA_REDEFINE_EXTNAME" on the command line stops all errors
and warnings in "lib/glob.c" compile.

> Thanks,

You're welcome,

> Derek

Conrad

/export/home/cvsusr/ccvs/cvs-1.12:$ make
make  all-recursive
Making all in lib
make  all-am
source='glob.c' object='glob.o' libtool=no \
DEPDIR=.deps depmode=gcc /bin/bash ../build-aux/depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I..    -Ino/include  -g -O2 -c glob.c
In file included from glob.h:100,
                 from glob.c:23:
/usr/include/sys/stat.h:175: warning: `lstat' redefined
../config.h:1135: warning: this is the location of the previous definition
glob.c: In function `rpl_glob':
glob.c:700: storage size of `st' isn't known
glob.c: In function `is_dir_p':
glob.c:1046: storage size of `st' isn't known
glob.c: In function `glob_in_dir':
glob.c:1094: storage size of `st' isn't known
*** Error code 1
make: Fatal error: Command failed for target `glob.o'
Current working directory /export/home/cvsusr/ccvs/cvs-1.12/lib
*** Error code 1
make: Fatal error: Command failed for target `all'
Current working directory /export/home/cvsusr/ccvs/cvs-1.12/lib
*** Error code 1
make: Fatal error: Command failed for target `all-recursive'
Current working directory /export/home/cvsusr/ccvs/cvs-1.12
*** Error code 1
make: Fatal error: Command failed for target `all'
/export/home/cvsusr/ccvs/cvs-1.12:$