Re: "make check" fails in fileutils-4.1 if SIMPLE_BACKUP_SUFFIX in env

[Jim Meyering]

Duncan Roe <address@hidden> wrote:
> fileutils/fileutils-4.1/tests/cp/backup-is-src doesn't take account that the
> user might have SIMPLE_BACKUP_SUFFIX in the environment: "make check" fails in
> this case.
>
> Because it's only the shell script's environment, I think it should be OK to
> simply remove SIMPLE_BACKUP_SUFFIX, as in the attached patch.
>
> It's not a simple job to replace ~ with a shell variable in this script 
> because
> of the <<\EOF

Thank you for the report and patch!
Using `unset' doesn't always work, so we have to be careful.
I've made this change:

Index: tests/cp/backup-is-src
===================================================================
RCS file: /fetish/cu/tests/cp/backup-is-src,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -p -u -r1.10 -r1.11
--- tests/cp/backup-is-src      8 Oct 2002 09:21:08 -0000       1.10
+++ tests/cp/backup-is-src      9 Oct 2002 08:09:57 -0000       1.11
@@ -6,6 +6,7 @@ if test "$VERBOSE" = yes; then
 fi
 
 . $srcdir/../lang-default
+. $srcdir/../envvar-check
 
 pwd=`pwd`
 t0=`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$