[Bug-gnu-arch] [bug #5635] library-file fails to find implicit (names) files in tagline method

[nobody]

=================== BUG #5635: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5635&group_id=4899

Changes by: Robert Collins <address@hidden>
Date: Tue 11/25/2003 at 13:32 (GMT)

------------------ Additional Follow-up Comments ----------------------------
address@hidden/tla--integration--1.1--patch-29 contains this, ready IMO for Tom.



=================== BUG #5635: FULL BUG SNAPSHOT ===================


Submitted by: cenderis                Project: GNU arch -- a revision control 
system
Submitted on: Tue 09/30/2003 at 11:00
Category:  tla                        Severity:  5 - Major                  
Bug Group:  bug                       Resolution:  None                     
Status:  Open                         Release:  head tla--devo--1.1--patch-187
Fixed Release:                        Merge Request?:  None                 
Your Archive Name:                    Your Archive Location:                
Assigned to:  None                    

Summary:  library-file fails to find implicit (names) files in tagline method

Original Submission:  This is presumably related to #5554.  In a working tree 
using

tagline method, files which are explicitly added or have a

tagline can be found in a library, but files which just have

the right name (foo.c, say) and are in fact in the revision

library aren't found (I get the message "file not found in

the library").

Follow-up Comments
*******************

-------------------------------------------------------
Date: Tue 11/25/2003 at 13:32       By: robertc
address@hidden/tla--integration--1.1--patch-29 contains this, ready IMO for Tom.

-------------------------------------------------------
Date: Wed 11/12/2003 at 04:53       By: gnubert
This should be fixed the same way as in #5554. Related to this, "library-file 
--this" didn't seem to work for untagged source files, when called in a 
different directory than the tree root. "larch library-file --help" suggests:



  "--this find the tag of FILE relative to the current directory, then find the 
corresponding file in the library"



This is similar to how file-diffs and file-find behave, but library-file 
currently does not (for untagged files). It would have to derive the project 
root from the specified file, and get a path of the file relative to that root. 
Otherwise arch_inventory_id will give the wrong id. I tried to fix this in the 
patches below. A function arch_tree_file_relpath has been added to 
project-tree.c (patch-26), that does the steps described above, and gets used 
by all three files, cmd-file-diffs.c, cmd-file-find.c, and cmd-library-file.c 
(patch-27, for the first two functions this reduces some code).



Archive Location:

  http://wmipf.in-berlin.de/{archives}/devel-2003



address@hidden/tla--wmipf--1.1--patch-24

    merge with lord

address@hidden/tla--wmipf--1.1--patch-25

    fix library-file and file-{find,diffs} for untagged files

address@hidden/tla--wmipf--1.1--patch-26

    add function arch_tree_file_relpath

address@hidden/tla--wmipf--1.1--patch-27

    use arch_tree_file_relpath




CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5635&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/