[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17809: 24.4.50; Completions display
From: |
Stefan Monnier |
Subject: |
bug#17809: 24.4.50; Completions display |
Date: |
Sun, 06 Jul 2014 00:32:46 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
> +(defmacro with-displayed-buffer-window (buffer-or-name action quit-function
> &rest body)
That looks OK. Two details, tho:
> + (setq ,window (temp-buffer-window-show ,buffer ,action)))
[...]
> + (when (functionp (cdr (assq 'window-height (cdr ,action))))
Let's not evaluate `action' twice. I.e. we need a (macroexp-let2 ..)
wrapper for it.
> + (if (functionp ,quit-function)
> + (funcall ,quit-function ,window ,value)
Same for quit-function, and additionally, we want to make sure we
evaluate `quit-function' before `body'.
Stefan
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/01
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/04
- bug#17809: 24.4.50; Completions display,
Stefan Monnier <=
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/06
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/06
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/06
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/07
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/07
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/08