[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17809: 24.4.50; Completions display
From: |
Stefan Monnier |
Subject: |
bug#17809: 24.4.50; Completions display |
Date: |
Sun, 06 Jul 2014 21:24:27 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
> === modified file 'lisp/window.el'
> --- lisp/window.el 2014-06-18 07:57:27 +0000
> +++ lisp/window.el 2014-07-06 23:32:27 +0000
> @@ -185,6 +185,7 @@ (defmacro with-temp-buffer-window (buffe
> (let ((buffer (make-symbol "buffer"))
> (window (make-symbol "window"))
> (value (make-symbol "value")))
> + (macroexp-let2 macroexp-copyable-p vquit-function quit-function
> `(let* ((,buffer (temp-buffer-window-setup ,buffer-or-name))
> (standard-output ,buffer)
> ,window ,value)
> @@ -192,9 +193,9 @@ (defmacro with-temp-buffer-window (buffe
> (with-current-buffer ,buffer
> (setq ,window (temp-buffer-window-show ,buffer ,action)))
>
> - (if (functionp ,quit-function)
> - (funcall ,quit-function ,window ,value)
> - ,value))))
> + (if (functionp ,vquit-function)
> + (funcall ,vquit-function ,window ,value)
> + ,value)))))
That looks right, except it means that `quit-function' is
evaluated before `buffer-or-name', which is contrary to the expectation
that arguments are usually evaluated left-to-right.
Stefan
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/01
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/04
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/06
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/06
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/06
- bug#17809: 24.4.50; Completions display,
Stefan Monnier <=
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/07
- bug#17809: 24.4.50; Completions display, Stefan Monnier, 2014/07/07
- bug#17809: 24.4.50; Completions display, Juri Linkov, 2014/07/08