bug#18332: 24.3.93; Convenience is a malformed function when installing ELPA package

[Fabrice Niessen]

Glenn Morris wrote:
> Fabrice Niessen wrote:
>
>> Anyway, I got the exact same problem in many other "ELPA" packages
>> (Dired+, Helm, YASnippet, etc.) though not all (not in Dired-single,
>> Fuzzy, Idle-require to name a few).
>>
>> Half wrong, half right. I had to delete the package-pkg.el(c) files, in
>> order to be able to launch Cygwin Emacs-w32. Dunno why the exact same
>> config works with native Emacs, and not with Cygwin, why both programs
>> go and fetch their packages at the same place on my file system...
>
> IIUC:
> If the problematic pkg.el file is on the server that you get the
> packages from, then that's a problem with that server and you should
> report it to whoever admins it.
>
> If it is not on the server but instead generated on your machine when
> you install the package, then please provide a minimum example starting
> from emacs -Q that shows the problem.

I understood that the problem depends on which Emacs version I'm using
to install the packages:

- with Emacs 24.3.1, it's OK: "keywords" list is correctly QUOTED in the
  generated `xxx-pkg.el' file.

- with Emacs 24.3.93.1 (of 2014-08-15), it's NOT, as you can see on
  http://screencast.com/t/ilxgafLbh.

Best regards,
Fabrice

PS- Here is my MWE file for launching Emacs:

--8<---------------cut here---------------start------------->8---
(require 'package)

;; archives from which to fetch
(setq package-archives
      (append '(("org"       . "http://orgmode.org/elpa/";)
                ("melpa"     . "http://melpa.milkbox.net/packages/";))
              package-archives))

;; load the latest version of all installed packages, and activate them
(package-initialize)

(defvar my/elpa-packages '(yasnippet)
  "A list of packages to ensure are installed at Emacs startup.")

(defun my/missing-elpa-packages ()
  "List packages to install which are neither built-in nor already installed."
  (let (missing-elpa-packages)
    (dolist (pkg my/elpa-packages)
      (unless (or (package-installed-p pkg)
                  (locate-library (symbol-name pkg)))
        (push pkg missing-elpa-packages)))
    missing-elpa-packages))

;; propose to install all the packages specified in `my/elpa-packages'
;; which are missing
(let ((missing-elpa-packages (my/missing-elpa-packages)))
  (when missing-elpa-packages
    ;; download once the ELPA archive description
    (package-refresh-contents)    ; Ensure that the list of packages is
                                  ; up-to-date.  Otherwise, new packages
                                  ; (not present in the cache of the ELPA
                                  ; contents) won't install.
    (dolist (pkg missing-elpa-packages)
      (if (yes-or-no-p (format "Install ELPA package `%s'? " pkg))
          (ignore-errors
            (package-install pkg)); must be run after initializing
                                  ; `package-initialize'
        (message (concat "Customize `my/elpa-packages' to ignore "
                         "the `%s' package at next startup...") pkg)
        (sit-for 1.5)))))

;; don't truncate package names in Emacs package list
(add-hook 'package-menu-mode-hook
          (lambda ()
            (setq tabulated-list-format
                  [("Package" 28 package-menu--name-predicate)
                   ("Version" 14 nil)
                   ("Status"  10 package-menu--status-predicate)
                   ("Description" 0 nil)])
            (tabulated-list-init-header)))
--8<---------------cut here---------------end--------------->8---