bug#24580: 25.2.50; query-replace history doesn't work

[Eli Zaretskii]

> Date: Sun, 2 Oct 2016 21:08:43 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: mbork@mbork.pl, 24580@debbugs.gnu.org
> 
> > > > The problem lies (at least) in query-replace-read-from, where
> > > > query-replace-from-to is let bound, and later read-from-minibuffer
> > > > refers to the symbol 'query-replace-from-to.  At first sight, it looks
> > > > like it could be fixed by putting some of the setup done by these
> > > > bindings into the minibuffer setup hook.
> > > 
> > > Isn't there a less intrusive change to fix this?  A significant change
> > > like the one you propose is more risky, but if there's no safer one, I
> > > guess we should take it.
> > 
> > Perhaps just adding a (defvar query-replace-from-to-history …) will be
> > sufficient.  That read-from-minibuffer and friends' HIST argument can
> > only be a symbol is a bit frustrating.
> 
> Surely there is a better way.

Isn't this exactly the minibuffer setup hook method that I wanted to
avoid?

Does a simple defvar you suggested before not work?

Thanks.