bug#24580: 25.2.50; query-replace history doesn't work

[Eli Zaretskii]

> Date: Mon, 3 Oct 2016 07:24:07 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: mbork@mbork.pl, 24580@debbugs.gnu.org
> 
> On 03/10/16 at 10:08am, Eli Zaretskii wrote:
> > > Date: Sun, 2 Oct 2016 12:51:28 -0400
> > > From: Mark Oteiza <mvoteiza@udel.edu>
> > > Cc: mbork@mbork.pl, 24580@debbugs.gnu.org
> > > 
> > > > > As for the other problem Marcin mentioned, that seems to be due to the
> > > > > custom-reevaluate-setting call in the same function.
> > > > 
> > > > I'm not sure I understand: what's wrong with
> > > > custom-reevaluate-setting in this case?
> > > 
> > > >From -Q:
> > > 
> > > 1. (setq-default query-replace-from-to-separator " => ")
> > > 2. Do an M-% (Like Marcin's in original recipe) once to get some default 
> > > in the prompt
> > > 3. M-%
> > > 
> > > I would expect to see (default a => b) in the prompt, but
> > > custom-reevaluate-setting apparently ignores settings done outside of
> > > customize.  The first step instead needs to be
> > > 
> > >   (custom-set-variables '(query-replace-from-to-separator " => "))
> > > 
> > > or something with the default for query-replace-from-to-separator should
> > > be changed.
> > 
> > OK, but is this a new problem related to turning on lexical-binding?
> 
> No.

Thanks, that's what I thought.  But it sounds like the use of
custom-reevaluate-setting is just a means to do something not
necessarily related to Customize, so I think avoiding the use of
custom-reevaluate-setting, and instead using char-displayable-p, at
least when not dumping, would provide a solution.

In any case, this is unrelated to lexical-binding, and is a separate
issue.