[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-const
From: |
Pip Cet |
Subject: |
bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant) |
Date: |
Sat, 20 Jul 2019 12:29:57 +0000 |
This code in ccl.c
eop = hash_lookup (h, make_fixnum (reg[RRR]), NULL);
if (eop >= 0)
{
Lisp_Object opl;
opl = HASH_VALUE (h, eop);
if (! (IN_INT_RANGE (eop) && CHARACTERP (opl)))
CCL_INVALID_CMD;
reg[RRR] = charset_unicode;
reg[rrr] = eop;
reg[7] = 1; /* r7 true for success */
}
else
reg[7] = 0;
seems wrong to me. We look up the hash value for reg[RRR], but then we
store the hash _index_ into reg[rrr], and throw away the actual value.
The bug appears to be present in:
commit d325055a00e658a38c1721fcc63ed1775dd8ccb3
Author: Dave Love <fx@gnu.org>
Date: Tue Jul 30 11:31:54 2002 +0000
which added the code, so I'm not sure whether there's external code
which might rely on the buggy behavior (unlikely, I think). Is there
any code actually making use of this CCL feature?
I'm playing around with hash tables and it would help to resolve this first.
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant),
Pip Cet <=
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Eli Zaretskii, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Eli Zaretskii, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Eli Zaretskii, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Pip Cet, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Andy Moreton, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Pip Cet, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Andy Moreton, 2019/07/20
- bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant), Pip Cet, 2019/07/21