[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-const
From: |
Pip Cet |
Subject: |
bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant) |
Date: |
Sun, 21 Jul 2019 06:01:10 +0000 |
On Sat, Jul 20, 2019 at 10:49 PM Andy Moreton <andrewjmoreton@gmail.com> wrote:
> > (defun ccl-fixnum (code)
> > "Convert a CCL code word to a fixnum value."
> > - (- (logxor (logand code #x0fffffff) #x08000000) #x08000000))
> > + (if (integerp code)
> > + (- (logxor (logand code #x0fffffff) #x08000000) #x08000000)
> > + code))
>
> `ccl-fixnum' should only receive integer arguments, so perhaps this fix
> should go in the call in `ccl-embed-data' instead:
>
> (aset ccl-program-vector ccl-current-ic
> (if (numberp data) (ccl-fixnum data) data))
Agreed, revised patch attached.
Note that the test leaks entries in translation-hash-table-vector, but
I think it's cleaner to start with a new symbol each time we run the
test.
0001-Fix-return-value-for-CCL-opcode-lookup-integer.patch
Description: Text Data