bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive


From: Lars Ingebrigtsen
Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
Date: Tue, 01 Sep 2020 17:06:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Robert Pluim <rpluim@gmail.com> writes:

>     >> -        (string-match comint-password-prompt-regexp string))
>     >> +        (string-match comint-password-prompt-regexp
>     >> +                        (replace-regexp-in-string "\r" "" string)))
>
>     Lars> Yes, that makes sense to me.
>
> Done in 2e3ec40293

One thought -- just as a precaution, would it make sense to do this
replacement only if the \r is at the start of a line, and it's not
followed by a \n?  I'm just slightly worried that there may be
repercussions on systems that use \r\n as end-of-line markers...  it
probably makes no difference here, but...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]