[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
From: |
Robert Pluim |
Subject: |
bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive |
Date: |
Tue, 01 Sep 2020 17:40:19 +0200 |
>>>>> On Tue, 01 Sep 2020 17:06:50 +0200, Lars Ingebrigtsen <larsi@gnus.org>
>>>>> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> >> - (string-match comint-password-prompt-regexp string))
>> >> + (string-match comint-password-prompt-regexp
>> >> + (replace-regexp-in-string "\r" "" string)))
>>
Lars> Yes, that makes sense to me.
>>
>> Done in 2e3ec40293
Lars> One thought -- just as a precaution, would it make sense to do this
Lars> replacement only if the \r is at the start of a line, and it's not
Lars> followed by a \n? I'm just slightly worried that there may be
Lars> repercussions on systems that use \r\n as end-of-line markers... it
Lars> probably makes no difference here, but...
Iʼm finding it hard to come up with a case where stripping the \r
fails (famous last words).
Robert