bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port

[Alan Third]

On Mon, Sep 14, 2020 at 01:11:30AM +0200, Lars Ingebrigtsen wrote:
> Dale Sedivec <dale@codefu.org> writes:
> 
> > The Emacs manual says[1], "the text shown under the cursor is drawn using
> > the frame’s background color."  However, on the NS port, the foreground
> > for text under the cursor seems to be taken from the face at point
> > rather than the frame's background color.
> >
> > [1]: 
> > https://www.gnu.org/software/emacs/manual/html_node/emacs/Cursor-Display.html
> >
> > To illustrate this, start emacs -Q and eval:
> >
> >     (progn
> >       (switch-to-buffer (generate-new-buffer "test"))
> >       (insert (propertize "testing"
> >                           'face '((:background "blue" :foreground 
> > "white"))))
> >       (goto-char 1))
> 
> It's not just the NS port, apparently -- I get the same in Debian.

Now you mention it, I can see that the X ports use the face colours as
well...

xterm.c:1518
      xgcv.background = s->f->output_data.x->cursor_pixel;
      xgcv.foreground = s->face->background;
           ^               ^
-- 
Alan Third