bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port

[Dale Sedivec]

On Sep 14, 2020, at 09:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Mon, 14 Sep 2020 01:49:43 +0200
>> Cc: 43381@debbugs.gnu.org, Dale Sedivec <dale@codefu.org>
>> 
>> Alan Third <alan@idiocy.org> writes:
>> 
>>> Now you mention it, I can see that the X ports use the face colours as
>>> well...
>>> 
>>> xterm.c:1518
>>>      xgcv.background = s->f->output_data.x->cursor_pixel;
>>>      xgcv.foreground = s->face->background;
>>>           ^               ^
>> 
>> Yeah, it looks like it's been like that since at least the 90s.  So...
>> the documentation is just wrong?
> 
> Yes, the documentation is inaccurate: it describes what happens when
> the text at point uses the default face.  When the face is not the
> default, we merge that face into the cursor face, and that is what you
> see.
> 
> We should fix the documentation.

Understood.  Would it be appropriate for me to open a separate bug for the 
problem of the text under the box cursor being nearly unreadable, as in my 
example?  Maybe allowing the cursor face's :foreground to be used in preference 
to the background of the face at point?

Dale