[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escape
From: |
Stefan Monnier |
Subject: |
bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped. |
Date: |
Thu, 24 Sep 2020 12:56:42 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> As already said, this is a(n ugly) workaround. syntax.c should handle
> comments in all their generality. With a bit of consideration, the
> method to do this is clear:
In my world, it's quite normal for a specific language's lexical rules
not to line up 100% with syntax tables (whether for strings, comments,
younameit). I don't see anything very special here.
A `syntax-propertize` rule for "\*/" should be very easy to implement
and fairly cheap since the regexp is simple and will almost never match.
So, yeah, you can add yet-another-hack on top of the other syntax.c
hacks if you want, but there's a good chance it will only ever be used
by CC-mode. It will take a lot more code changes in syntax.c than
a quick tweak to your Elisp code to search for "\*/".
I do think it would be good to handle this without `syntax-table`
text-property hacks, but I think that should come with an overhaul of
syntax.c based on a major-mode provided DFA (or something like that) so
it can accommodate all the various oddball cases without even the need
to introduce the notion of escaping comment markers.
Stefan
- bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped., Alan Mackenzie, 2020/09/22
- bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped., Mattias EngdegÄrd, 2020/09/23
- bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped., Michael Welsh Duggan, 2020/09/24
- bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped., Alan Mackenzie, 2020/09/24
- bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped., Michael Welsh Duggan, 2020/09/24