bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces


From: Eli Zaretskii
Subject: bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces
Date: Fri, 15 Jan 2021 14:11:27 +0200

> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sat, 9 Jan 2021 20:56:35 -0600
> Cc: martin rudalics <rudalics@gmx.at>, 45748@debbugs.gnu.org
> 
> Let me know how this looks and if you want me to make any tweaks.

Thanks, I installed this on the master branch.

However, the new tests fail for me in batch execution on MS-Windows
with this error:

  Test xdisp-tests--window-text-pixel-size condition:
      (error "Not using an ASCII terminal now; cannot make a new ASCII frame")

It works if I run the test interactively.

The backtrace is

  make-terminal-frame(((parent-frame . #<frame F1 062dca38>)))
  tty-create-frame-with-faces(((parent-frame . #<frame F1 062dca38>)))
  #f(compiled-function (params) #<bytecode 0x6bc24af6be4b5d2>)(((paren
  apply(#f(compiled-function (params) #<bytecode 0x6bc24af6be4b5d2>) (
  frame-creation-function(((parent-frame . #<frame F1 062dca38>)))
  make-frame(((parent-frame . #<frame F1 062dca38>)))
  display-buffer-in-child-frame(#<killed buffer> nil)
  display-buffer(#<killed buffer> (display-buffer-in-child-frame))
  (let* ((window (display-buffer (current-buffer) '(display-buffer-in-
  (progn (insert "xx ") (let* ((window (display-buffer (current-buffer
  (unwind-protect (progn (insert "xx ") (let* ((window (display-buffer
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (closure (t) nil (let ((temp-buffer (generate-new-buffer " *temp*" t
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name xdisp-tests--window-text-pixel-size-t
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)

I guess you are assuming some functionality that isn't supported on
all platforms?  Can you please rewrite the tests so that they work on
all platforms?

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]