bug#49888: 28.0.50; fido-mode not sorting by recency

[João Távora]

João Távora <joaotavora@gmail.com> writes:

> Manuel Uberti <manuel.uberti@inventati.org> writes:
>
>> In 'emacs -Q', this is what I did:
>>
>> - M-x savehist-mode RET
>> - M-x fido-mode RET
>> - M-x icomplete-vertical-mode RET
>> - M-x emacs-init-time
>> - C-x p p, pick a Git-versioned directory RET
>> - f, pick the fourth candidate, C-x k RET
>> - M-x now shows pr-ps-file-preview on top
>> - C-x p p, pick the only available project
>> - C-x p f does not offer the previously selected candidate
>>
>> Is it possible to make fido-mode sort the candidates by recency?
>
> I've now taken a look at this.  Yes, it is certainly possible and
> desirable _if_ there aren't any other overriding criteria.  This has to
> do with the 'flex' completion style.  In that style, if anything has
> been input that leads to "flexy" filtering, the default and correct
> behaviour is to sort by completion score.
>
> But if nothing has been input and there are basically no scores, it
> makes sense to fall back to a sensible strategy like the one you
> suggest.
>
> Try this patch.  It will fix the M-x case, bugt not the C-x p f or C-x f
> cases unfortunately.  Those will be harder to fix.

Actually, I correct that.  C-x f will be harder to fix, but C-x p f and
C-x p p RET f work just fine!

So I think I will commit this correction to the flex completion style.
It's indeed extremely useful, especially for C-x p f, which I now also
use a lot.

João