bug#47047: [External] : Re: bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal

[Drew Adams]

> > You're free to delete light-blue-theme, if you like.
> > I don't use it, myself, and I won't miss it.
> 
> Any other opinions about this part?
> 
> I'm leaning towards just deleting it given the above.

Lean away.  However, I don't see the point
of deleting a theme because you find that
the default appearance of a face you defined
looks, according to you, "out of place" with
that theme.

The bug of this thread is that the default
background of a (new) face is suboptimal.  Is
there also some bug with the light-blue-theme?

You say that you think the new background you
chose for that new face looks out of place
with that theme.  Maybe file a bug report for
that?

What's the relation between the background you
chose to use by default and the definition of
_any_ theme?  Tail wagging dog?  I'm pretty
sure that, for any theme, you can find a color
that you'll think looks out of place.

Emacs 28 isn't even released yet.  You add a
face and then want to purge stuff that you
find "looks out of place" with your new face?

I won't try to stop you.  But I find such a
purge a bit "out of place".

FWIW, I looked at a face with background
"gray90", which from the bug thread I gather
is the default you chose.

(defface foo '((t (:background "gray90")))
  :group 'convenience)

I looked at it in my setup (which is about
the same as `light-blue-theme'), with
`list-faces-display'.  Seems to show up OK.
(See attached screenshot.)  Just how does
it look "out of place" to you?

If the point is about legibility/accessibility
then what counts is the value contrast between
foreground and background (nothing else really
counts).  Assuming your face doesn't change the
foreground, the legibility of the face stands
on its own: the value difference between its
foreground (black?) and its background, gray90.

As for the face itself (its background)
standing out against a general background that
has a similar color value: yes, that hinders
accessibility.  Someone with difficulty seeing
low value-contrast differences likely wouldn't
choose that theme anyway, or s?he might want to
customize some faces (including that new face).

An advantage of a pale (but not close to white)
background is the ability to easily see a range
of foreground colors, including very light and
very dark, but also mid-range (foregrounds and
backgrounds) if the hue is quite different.  As
with any theme or color scheme (and any face,
including this new one), it's optional and
configurable.

throw-gray90-bg.png
Description: throw-gray90-bg.png