bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#47047: [External] : Re: bug#47047: 28.0.50; 'help-key-binding' face'


From: Drew Adams
Subject: bug#47047: [External] : Re: bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal
Date: Wed, 29 Sep 2021 19:50:57 +0000

> > Do we have some reason to deprecate this theme,
> > beyond someone finding that a new face "looks
> > out of place" when that theme is used?
> > It's always good to see an actual reason.
> 
> FWIW, I would personally object to removing a theme 
> on non-technical grounds.
> 
> In any case, you objected, and AFAIU you are still the maintainer so in
> that sense there is nothing to discuss here.  The theme is staying, at
> least until our maintainers say otherwise (the same as for all things).
> 
> As for reasons to remove a theme, I wrote before:
> 
>     "We have more than one theme that is buggy, has low coverage and/or
>     is not maintained, so maybe this is something we should think
>     about."
> 
> I can't say if it is buggy or not, but I think it has low coverage, and
> it is clearly maintained only sparingly.

FWIW, I agree with what you wrote there.

Except for a few nits:

1. IMO, bugginess of a theme should matter (should
   be thought about, as you put it), but low usage
   (coverage?) should not.  Why remove a theme just
   because it's seldom used?

2. Once again: I have NOT objected to deleting the
   theme.  I asked about technical reasons to do so.

3. I have no idea who the "maintainer" of that theme is.
   We were asked to contribute themes when custom themes
   became a possibility, and I sent that one.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]