bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then' is on 'if' line

[Lars Ingebrigtsen]

Doug Maxey <emacs-bugs@maxeygroup.tech> writes:

> However, lots'o bash gets written here, and one of my idioms is:
> <code>
> if test;then
>    do something
> fi
>    ^
> </code>

The problem seems to be here:

(defun sh-smie--default-backward-token ()
[...]
            (progn (skip-syntax-backward ".w_'")
                   (or (not (zerop (skip-syntax-backward "\\")))
                       (when (eq ?\\ (char-before (1- (point))))

Semi-colons have punctuation syntax, so we're skipping back over the
entirety of "test;then" instead of stopping after "then".

This looks easy enough to fix, but the overall logic of that function is
somewhat obscure to me, so I've added Stefan to the comments; perhaps he
has some comments.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no