bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then'


From: Doug Maxey
Subject: bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then' is on 'if' line
Date: Sun, 06 Feb 2022 18:14:45 -0600
User-agent: Evolution 3.42.3 (3.42.3-1.fc35)

On Sun, 2022-02-06 at 19:11 -0500, Stefan Monnier wrote:
(defun sh-smie--default-backward-token ()
[...]
            (progn (skip-syntax-backward ".w_'")
                   (or (not (zerop (skip-syntax-backward "\\")))
                       (when (eq ?\\ (char-before (1- (point))))

Semi-colons have punctuation syntax, so we're skipping back over the
entirety of "test;then" instead of stopping after "then".

We should indeed only skip over "then", and then only over ";" and then
only over "test".

This looks easy enough to fix, but the overall logic of that function is
somewhat obscure to me, so I've added Stefan to the comments; perhaps he
has some comments.

The sh syntax is fairly nasty to parse, especially backwards, so I can't
give you any general comment here.  I'd try something and then see if it
breaks any tests (including looking at test/manual/indent/shell.sh).

For sure, I'd recommend adding a regression test.

just a further point, if it helps, this was fine in 27.2.
 


        Stefan


Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]