bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53853: [PATCH] Don't use string-replace in flymake


From: João Távora
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 8 Feb 2022 09:52:34 +0000

On Tue, Feb 8, 2022 at 9:26 AM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Brian Leung <leungbk@posteo.net> writes:
    >> OK, I've updated the patch per your suggestions. I've also made the
    >> commit apply to the emacs-28 branch, as opposed to the master branch.

    Lars> Thanks; pushed to emacs-28.

Iʼm not au fait with how core packages work, does this require a bump
in flymake's package version?

Yes, Robert, I believe so. Else the core package won't get regenerated into GNU ELPA.

What _doesn't_ require a bump is, for example, `eglot.el` usage of it.  So if you
bump flymake.el to, say, 1.9 now and eglot.el is still asking for 1.8, I think package.el
will pull in the latest one regardless and the problem for eglot.el users will be fixed.

I suspect though, that this problem only happened because the user was using
the straight.el package manager, which will try to fetch the very latest (i.e.
not go through GNU ELPA as package.el does).

Anyway, thanks for fixing this.
João

reply via email to

[Prev in Thread] Current Thread [Next in Thread]