bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#53853: [PATCH] Don't use string-replace in flymake


From: Robert Pluim
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 08 Feb 2022 16:07:33 +0100

>>>>> On Tue, 8 Feb 2022 14:09:34 +0000, João Távora <joaotavora@gmail.com> 
>>>>> said:

    João> Well, technically, I did "show the patch" even though I didn't author 
said
    João> patch myself. I answered:

    >> It would seem that the right thing to do is to keep 26.1 dep and do what
    João> Guillaume Pasquet suggests:
    >> "or substitute the `string-replace` call with `replace-regexp-in-string`
    João> to maintain compatibility as I have done here:
    >> 
    João> 
https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22

    João> Anyway, all good now, just bring the Emacs dep down to 26.1.  Thanks.

Just so weʼre all clear, we want this in emacs-28 (on top of Lars's
change to use `replace-regexp-in-string'?

Attachment: 0001-Mark-flymake-as-compatible-with-emacs-26.1.patch
Description: Text Data

Robert
-- 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]