bug#53853: [PATCH] Don't use string-replace in flymake

[João Távora]

Eli, how are you?  I hope well.

This change:

commit 6b8957852476e4ba31873424aa8f81d9e55bc34c
Author: Eli Zaretskii <eliz@gnu.org>
Date:   Thu Dec 9 17:01:57 2021 +0200

    ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -9,1 +9,1 @@
-;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))

breaks "downstream" users of flymake.el as a "core" package, eglot.el

most notably. 

Can you explain it?  I'm not 100% sure if we have discussed this before.

If we have, I'm very sorry, but I forgot the context.

Thanks,

João

On Tue, Feb 8, 2022 at 9:54 AM João Távora <joaotavora@gmail.com> wrote:

On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim <rpluim@gmail.com> wrote:

>>>>> On Tue, 8 Feb 2022 09:20:07 +0000, João Távora <joaotavora@gmail.com> said:

    João> I'm not in front of my computer right now, but as far as I recall, there is
    João> a note in the preamble of flymake.el asking maintainers not to use
    João> functionality incompatible with the given emacs dependency.

There is, and the current flymake.el says emacs-28.

Does it?  That's news to me.  It shouldn't, I think.  That breaks a lot of downstream

users, eglot.el most notably.

I have to M-x vc-region-history that bit.

João

--

João Távora