bug#53853: [PATCH] Don't use string-replace in flymake

[João Távora]

Alright.  Seems that the discussion died down and there was never the fix and

reversion we (presumably?) agreed on. So I think if the incompatible string-something has

been now replaced by the replace-regexp-something that is compatible, we should now

put the 26.1 in the header again.  If everyone agrees, I ask someone with a Emacs

master/emacs-28 checkout nearby to do that change and also bump flymake.el's version.

Robert maybe? Thanks in advance.

On Tue, Feb 8, 2022 at 1:04 PM Eli Zaretskii <eliz@gnu.org> wrote:

> From: João Távora <joaotavora@gmail.com>
> Date: Tue, 8 Feb 2022 09:58:06 +0000
> Cc: Brian Leung <leungbk@posteo.net>, Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
>
> This change:
>
> commit 6b8957852476e4ba31873424aa8f81d9e55bc34c
> Author: Eli Zaretskii <eliz@gnu.org>
> Date:   Thu Dec 9 17:01:57 2021 +0200
>
>     ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
>
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -9,1 +9,1 @@
> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
>
> breaks "downstream" users of flymake.el as a "core" package, eglot.el
> most notably. 
>
> Can you explain it?  I'm not 100% sure if we have discussed this before.
> If we have, I'm very sorry, but I forgot the context.

Asked and answered, see

  https://lists.gnu.org/archive/html/emacs-devel/2021-12/msg01898.html
  https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html

--

João Távora